[ACT-242] Upgrade node-fetch through segment fork of cross-fetch #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prayansh
reviewed
Oct 27, 2022
| import { isObject } from './real-type-of' | ||
| import type https from 'https' | ||
|
|
||
| const REQUEST_HIGH_WATER_MARK = process.env.REQUEST_HIGH_WATER_MARK | ||
| ? parseInt(process.env.REQUEST_HIGH_WATER_MARK) | ||
| : undefined |
There was a problem hiding this comment.
shouldnt the default value be something of the same type? maybe 0. Is this a common pattern in ts?
There was a problem hiding this comment.
node-fetch has a default built in, so we end up using that if we pass undefined.
I'll leave a comment so that's more clear!
dlasky
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of your pull request, including the what change you're making and why.
Currently, requests that have response bodies larger than 16kb hang because of an issue with node-fetch. They fixed the issue in their v3 release. We use node-fetch via cross-fetch. Cross-fetch has no upgraded to node-fetch v3.x, and has no plans to do so.
In order to use node-fetch v3.x+, we needed to fork cross-fetch and upgrade node-fetch in our forked package. This PR implements the forked package.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.