Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map full event context in Ripe Cloud Mode #2035

Merged

Conversation

simpajj
Copy link
Contributor

@simpajj simpajj commented May 14, 2024

Mapping of the full event context in the Ripe Cloud Mode destination.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@tcgilbert
Copy link
Contributor

hi @simpajj - our partner engineer who reviews these PRs is currently out of office but will be back Thursday. If there is absolute urgency behind this PR, or you have any questions, let me know.

@simpajj
Copy link
Contributor Author

simpajj commented May 15, 2024

hi @simpajj - our partner engineer who reviews these PRs is currently out of office but will be back Thursday. If there is absolute urgency behind this PR, or you have any questions, let me know.

Hi @tcgilbert
Thanks for informing us! Do you know when they're back? It's a bit of an urgent one unfortunately.

@joe-ayoub-segment joe-ayoub-segment self-assigned this May 16, 2024
@joe-ayoub-segment joe-ayoub-segment merged commit 84aaceb into segmentio:main May 21, 2024
10 of 11 checks passed
@joe-ayoub-segment
Copy link
Contributor

hi @simpajj this PR has been deployed

@joe-ayoub-segment
Copy link
Contributor

Please confirm the change looks good!

@simpajj
Copy link
Contributor Author

simpajj commented May 27, 2024

Please confirm the change looks good!

Looks good on our end! Thanks @joe-ayoub-segment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants