[STRATCONN-3772] | Add new operator "number_equals" for number #2030
Conversation
Innovative-GauravKochar
changed the title
Innovative-GauravKochar
changed the title
|
Can you please add staging testing doc here, if you have tested it in staging ? |
| expect(validate(ast, { properties: { value: '123' } })).toEqual(true) | ||
| expect(validate(ast, { properties: { value: 0 } })).toEqual(false) | ||
| } | ||
| }) | ||
|
|
||
| test('operators - is equals to (==) (numbers)', () => { |
There was a problem hiding this comment.
Would you mind clarifying why we are testing against string and ints on the file above but not here? Also, please describe a use case where this will be used so I can understand it a bit better. Thanks!
There was a problem hiding this comment.
@marinhero Here is an analysis doc of the problem we are trying to solve. Let me know if you have any doubts.
| @@ -165,6 +165,9 @@ const parseFqlFunction = ( | |||
| } | |||
| } | |||
|
|
|||
| const parseOperator = (valueToken: Token, operatorToken: Token) => | |||
| valueToken.type === 'number' && operatorToken.value === '=' ? '==' : (operatorToken.value as Operator) | |||
There was a problem hiding this comment.
Why do we override operator value = in parser? Can we try to restrict possible values on the app side?
There was a problem hiding this comment.
Changes in the app is side will introduce ambiguity. Also, After the expression is formed, we would have transform this every time there is a change the expression.
Plus, App relies on this to parse FQL to AST.
itsarijitray
changed the title
Summary
Jira Ticket: https://segment.atlassian.net/browse/STRATCONN-3772
Addition of a new operator ("number_equals") in validate, parse-fql and generate-fql functions in @segment/destination-subscriptions.
This operator does a strict numeric equality check. This operator is only at the AST level and doesn't get stored in the actual fql. Before generating fql, This operator will be transformed into "=" without stringifying its corresponding value token.
Analysis Doc: https://docs.google.com/document/d/1hhVGplvnzTveGDpV5OS6v4tdYPSCSQiI7rLuitIyKp0/edit#heading=h.wc5kl9crigkj
!!!Important: Please follow these steps after merging.
Testing
Stage Test Doc: https://docs.google.com/document/d/1QjirLSefl3HlCphxlTgwIYn7EjO0vgMkpEOGxXMhask/edit?usp=sharing