Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force @jest/types resolution in templates #468

Merged
merged 3 commits into from Jul 8, 2021
Merged

Force @jest/types resolution in templates #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aa6463
Force `@jest/types` resolution in templates
72636c Jul 8, 2021
8eac635
Update CDK snapshot
72636c Jul 8, 2021
43dcb6b
Try adding direct `@types/node` deps
72636c Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clean-needles-remember.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'skuba': patch
---

**template:** Force `@jest/types` resolution to fix clean installs
3 changes: 3 additions & 0 deletions template/express-rest-api/package.json
View file
Open in desktop
Expand Up @@ -17,6 +17,9 @@
},
"license": "UNLICENSED",
"private": true,
"resolutions": {
"**/@jest/types/@types/node": "^15.0.0"
},
"scripts": {
"build": "skuba build",
"format": "skuba format",
Expand Down
3 changes: 3 additions & 0 deletions template/greeter/package.json
View file
Open in desktop
Expand Up @@ -11,6 +11,9 @@
},
"license": "UNLICENSED",
"private": true,
"resolutions": {
"**/@jest/types/@types/node": "^15.0.0"
},
"scripts": {
"build": "skuba build",
"format": "skuba format",
Expand Down
3 changes: 3 additions & 0 deletions template/koa-rest-api/package.json
View file
Open in desktop
Expand Up @@ -31,6 +31,9 @@
},
"license": "UNLICENSED",
"private": true,
"resolutions": {
"**/@jest/types/@types/node": "^15.0.0"
},
"scripts": {
"build": "skuba build",
"format": "skuba format",
Expand Down
22 changes: 22 additions & 0 deletions template/lambda-sqs-worker-cdk/infra/__snapshots__/appStack.test.ts.snap
View file
Open in desktop
Expand Up @@ -133,6 +133,17 @@ Object {
},
"Resource": "*",
},
Object {
"Action": Array [
"kms:Decrypt",
"kms:GenerateDataKey",
],
"Effect": "Allow",
"Principal": Object {
"Service": "sns.amazonaws.com",
},
"Resource": "*",
},
],
"Version": "2012-10-17",
},
Expand Down Expand Up @@ -543,6 +554,17 @@ Object {
},
"Resource": "*",
},
Object {
"Action": Array [
"kms:Decrypt",
"kms:GenerateDataKey",
],
"Effect": "Allow",
"Principal": Object {
"Service": "sns.amazonaws.com",
},
"Resource": "*",
},
],
"Version": "2012-10-17",
},
Expand Down
3 changes: 3 additions & 0 deletions template/lambda-sqs-worker-cdk/package.json
View file
Open in desktop
Expand Up @@ -20,6 +20,9 @@
},
"license": "UNLICENSED",
"private": true,
"resolutions": {
"**/@jest/types/@types/node": "^15.0.0"
},
"scripts": {
"build": "skuba build",
"format": "skuba format",
Expand Down
3 changes: 3 additions & 0 deletions template/lambda-sqs-worker/package.json
View file
Open in desktop
Expand Up @@ -23,6 +23,9 @@
},
"license": "UNLICENSED",
"private": true,
"resolutions": {
"**/@jest/types/@types/node": "^15.0.0"
},
"scripts": {
"build": "skuba build",
"deploy": "yarn build && serverless deploy --force --verbose",
Expand Down
4 changes: 4 additions & 0 deletions template/oss-npm-package/_package.json
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@
"dependencies": {},
"description": "<%- description %>",
"devDependencies": {
"@types/node": "^15.0.0",
"commitizen": "^4.2.3",
"skuba": "*"
},
Expand All @@ -19,6 +20,9 @@
"type": "git",
"url": "git+https://github.com/<%- orgName %>/<%- repoName %>.git"
},
"resolutions": {
"**/@jest/types/@types/node": "^15.0.0"
},
"scripts": {
"build": "skuba build-package",
"commit": "cz",
Expand Down
4 changes: 4 additions & 0 deletions template/private-npm-package/_package.json
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@
"dependencies": {},
"description": "<%- description %>",
"devDependencies": {
"@types/node": "^15.0.0",
"commitizen": "^4.2.3",
"skuba": "*"
},
Expand All @@ -19,6 +20,9 @@
"type": "git",
"url": "git+https://github.com/<%- orgName %>/<%- repoName %>.git"
},
"resolutions": {
"**/@jest/types/@types/node": "^15.0.0"
},
"scripts": {
"build": "skuba build-package",
"commit": "cz",
Expand Down