enable a few ESLint rules

[mrm007]

Rules enabled:

• @typescript-eslint/consistent-type-imports
• import/no-duplicates
• import/no-relative-packages

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1bd1480

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mrm007]

Converting to draft while I tweak a few ESLint settings.

@seek-oss/braid-maintainers how do we feel about @typescript-eslint/consistent-type-imports?

[michaeltaranto]

Converting to draft while I tweak a few ESLint settings.

@seek-oss/braid-maintainers how do we feel about @typescript-eslint/consistent-type-imports?

I quite like the explicitness. Does that disallow single-lined multi-typed imports? Eg.

import { fn, Foo } from 'Foo';

(where fn is a function and Foo is a type)

[mrm007]

@michaeltaranto

The rule auto-fixes

import { fn, Foo } from 'foo';

to

import type { Foo } from 'foo';
import { fn } from 'Foo';

But if you (re)write it as

import { fn, type Foo } from 'foo';

that's also valid

[michaeltaranto]

Is the thinking that we will touch many of these files twice now? Once to extract type imports to standalone imports, and a second to revert to inline when the plugin supports that preference?

Outside of that, a few other minor comments.

[michaeltaranto]

Should we add this now or later when typescript-eslint/typescript-eslint#4338 is done?

Have we considered this going into eslint-config-seek or too opinionated you think?

[mrm007]

If TypeScript 4.5 is a blocker, I would add it later; forgot to remove it now.

Same thing with adding it to eslint-config-seek, aside from being (too) opinionated. If TS 4.5 stops people from upgrading, then it's not great.

[michaeltaranto]

Looks good to me 😅