Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sr threaded mode: fix timeout #4387

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented May 12, 2024

Context: threaded mode in sr(p)(1) is useful when sending a ton of packets (for instance, an arping on a big range).

  • when threaded mode is used in sr(p)(1), timeout is rendered ineffective. Fix that
  • use threaded mode in arping by default

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.56%. Comparing base (29b5413) to head (fb9975a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4387      +/-   ##
==========================================
- Coverage   81.56%   81.56%   -0.01%     
==========================================
  Files         352      352              
  Lines       83601    83620      +19     
==========================================
+ Hits        68193    68205      +12     
- Misses      15408    15415       +7     
Files Coverage Δ
scapy/layers/l2.py 84.41% <100.00%> (ø)
scapy/sendrecv.py 87.21% <77.77%> (-0.23%) ⬇️

... and 3 files with indirect coverage changes

@gpotter2 gpotter2 merged commit ecfeb14 into secdev:master May 12, 2024
22 of 23 checks passed
@gpotter2 gpotter2 deleted the threaded-timeout branch May 12, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant