Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several contrib layers cleanups #3939

Merged
merged 4 commits into from Mar 12, 2023
Merged

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Mar 11, 2023

@gpotter2 gpotter2 added the cleanup Performs some code clean-up label Mar 11, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #3939 (9087b50) into master (181aa4d) will decrease coverage by 0.15%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #3939      +/-   ##
==========================================
- Coverage   81.77%   81.62%   -0.15%     
==========================================
  Files         327      326       -1     
  Lines       74712    75429     +717     
==========================================
+ Hits        61093    61569     +476     
- Misses      13619    13860     +241     
Impacted Files Coverage Δ
scapy/layers/eap.py 91.16% <78.94%> (-1.74%) ⬇️
scapy/__init__.py 84.50% <100.00%> (ø)

... and 16 files with indirect coverage changes

@gpotter2
Copy link
Member Author

Hi @p-l- @guedou, this is ready for review.

Wanted to ask if it's okay to remove ubberlogger

Copy link
Member

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@gpotter2 gpotter2 merged commit d05de38 into secdev:master Mar 12, 2023
19 checks passed
@gpotter2 gpotter2 deleted the fix-pypy39-tests branch March 12, 2023 12:58
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Performs some code clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants