New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Simple Two-Way Active Measurement Protocol (STAMP) #3742
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3742 +/- ##
==========================================
+ Coverage 86.00% 86.05% +0.05%
==========================================
Files 299 301 +2
Lines 68111 68341 +230
==========================================
+ Hits 58579 58811 +232
+ Misses 9532 9530 -2
|
067dd98
to
030df4f
Compare
@gpotter2 Many thanks for the quick review. I addressed all your suggestions and force-updated the branch. |
030df4f
to
db4acc2
Compare
@gpotter2 I updated the PR to fix some docstring warnings reported by Sphinx |
Build doc is failing with the following error:
This is due to a bug in The problem is described here: sphinx-doc/sphinx#10853 (comment) Maybe we need a workaround waiting for the PR to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is looking good, just two minor questions !
This commit adds the support for Simple Two-Way Active Measurement Protocol (STAMP). Simple Two-Way Active Measurement Protocol: https://www.rfc-editor.org/rfc/rfc8762.html Simple Two-Way Active Measurement Protocol Optional Extensions: https://www.rfc-editor.org/rfc/rfc8972.html Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
db4acc2
to
997d33e
Compare
@gpotter2 Thank you for the great review! I added source port binding and force-pushed the branch. |
This PR adds the support for the Simple Two-Way Active Measurement Protocol (STAMP) to Scapy. STAMP enables the measurement of both one-way and round-trip performance metrics, like delay, delay variation, and packet loss.
This PR implements the main specifications of STAMP described in RFC 8762 and the STAMP Test Session Identifier (SSID) defined in Section 3 of RFC 8972.
Signed-off-by: Carmine Scarpitta carmine.scarpitta@uniroma2.it