Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the color module scale method instead of darken function #604

Merged
merged 1 commit into from May 29, 2021

Conversation

sebnitu
Copy link
Owner

@sebnitu sebnitu commented May 29, 2021

Problem

The darken() function is not directly included in the new module system. That's because it's not usually the best way to make a color darker. We should look into replacing all usages of darken() with color.scale() instead.

Solution

This PR replaces all usages of darken() with the Sass module color scale method color.scale().

@sebnitu sebnitu merged commit ce639fd into master May 29, 2021
@sebnitu sebnitu deleted the refactor-darken-function branch May 29, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant