Fix setTabindex from removing tabindex attributes when set to false #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
fix-tabindex-disable
branch
from
5d48254
to
227e0b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when setting the
setTabindexoption tofalseon either@vrembem/modalor@vrembem/drawercomponents, they will remove thetabindexattribute from the components specific dialog elements. Tabindex should instead just not be applied while any manually settabindexattributes should be unaltered.Solution
This PR removes the state parameter from the core setTabindex function and no longer removes manually added tabindex attributes if the setTabindex option is set to false. This effects both
@vrembem/modaland@vrembem/drawercomponents.