Rename type modifier to state to be more accurate #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a few components that use the
_type_[value]
modifier for displaying variants ofinfo
,success
,caution
anddanger
states. These should be more accurately renamed to_state_[value]
modifiers which will better align with how they're used by theinput
component which already as a_type_[value]
modifier. The input's_type_[value]
modifier is used for setting an inputs type of form control (matching the attribute equivalent) styles.Solution
This PR renames the
_type_[value]
modifier to_state_[value]
for theicon-action
andnotice
components. This better aligns with how the modifier is used on theinput
component and their purpose.Ref Issue: Fixes #589