Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and refactor the input and button components #580

Merged
merged 21 commits into from May 26, 2021
Merged

Conversation

sebnitu
Copy link
Owner

@sebnitu sebnitu commented May 12, 2021

Problem

The input component needs to be audited, cleaned up and have it's docs written.

Solution

This PR adds the missing input component README documentation and updates it's docs page to match. This also includes some major refactoring of the input component along with some minor button component consistency changes. Here are the majority of the changes made:

  • Added calc-padding(padding, border-width)
  • Added button styles to button component
  • Added border width, style and color vars to button and input components
  • Added example forms (example.html) to input component
  • Refactored input component styles
  • Removed input_color_invert modifier
  • Refactored input_state_[value] modifier
  • Refactored input_type_textarea modifier
  • Refactor input box-shadow() mixin

@sebnitu sebnitu changed the title Add README docs for input component Audit and refactor the input component May 13, 2021
@sebnitu sebnitu force-pushed the docs-readme-input branch 3 times, most recently from 3b13a1a to dcb86ee Compare May 25, 2021 05:28
@sebnitu sebnitu changed the title Audit and refactor the input component Audit and refactor the input and button components May 26, 2021
@sebnitu sebnitu marked this pull request as ready for review May 26, 2021 05:36
@sebnitu sebnitu merged commit 42a21a1 into master May 26, 2021
@sebnitu sebnitu deleted the docs-readme-input branch May 26, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant