New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit and refactor the input and button components #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
changed the title
Add README docs for input component
Audit and refactor the input component
May 13, 2021
sebnitu
force-pushed
the
docs-readme-input
branch
3 times, most recently
from
May 25, 2021 05:28
3b13a1a
to
dcb86ee
Compare
sebnitu
force-pushed
the
docs-readme-input
branch
from
May 26, 2021 02:14
458549d
to
6d74f08
Compare
sebnitu
changed the title
Audit and refactor the input component
Audit and refactor the input and button components
May 26, 2021
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The input component needs to be audited, cleaned up and have it's docs written.
Solution
This PR adds the missing input component README documentation and updates it's docs page to match. This also includes some major refactoring of the input component along with some minor button component consistency changes. Here are the majority of the changes made:
calc-padding(padding, border-width)
example.html
) to input componentinput_color_invert
modifierinput_state_[value]
modifierinput_type_textarea
modifierbox-shadow()
mixin