Audit and refactor the icon-action component #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
docs-readme-icon-action
branch
from
7f83a13
to
1f37f46
Compare
sebnitu
force-pushed
the
docs-readme-icon-action
branch
from
56af910
to
efe52e0
Compare
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The icon-action component needs to be audited, cleaned up and have it's docs written.
Solution
This PR does a full audit of the icon-action component, cleaning things up and adds the README docs as well as reflects changes to the docs page. The audit includes the following component refactors:
icon-action_color_[key]modifier toicon-action_type_[key]to better reflect its intent.icon-action_type_infomodifier for informational action type buttons.