Add new flex-gap and gap modules #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
add-gap-module
branch
4 times, most recently
from
a23dc58
to
08dd65c
Compare
sebnitu
force-pushed
the
add-gap-module
branch
from
08dd65c
to
985b64e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's a commonly used gap pattern that could be extracted into a reusable module.
Solution
This PR adds the
flex-gapandgapmodules for handling spacing between children elements of a component, similar to the Flebox gap property. Flex components have been refactored to remove redundant styles and allow these new modules to handle their gap styles.New mixin
@vrembem/core→flex-gap()@vrembem/core→gap()New Utilities:
flex-gap-[key]flex-gap-x-[key]flex-gap-y-[key]gap-y-[key]gap-y-[key]Deprecated module:
spacing- now being handled bygap-y