New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular component scripts #320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created focus and transition modules to be shared with modal and drawer components.
sebnitu
force-pushed
the
modular-component-scripts
branch
from
August 15, 2020 17:49
47cf786
to
bd65754
Compare
also adds innerElement condition to tabbing handler
This was referenced Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current Vrembem JavaScript components are written in a single file. This can make it hard to understand their features, test and keep organized.
Solution
This PR re-writes Vrembem's JavaScript components to be more module. Each components module entry is through their
index.js
file where a factory function written in ES6 classes is defined. From there, all functionality is split into their own module files and shared features between modules has been moved into@vrembem/core
in their own modules.A few of the now shared
@vrembem/core
modules include:accessibility
{ setInert, setOverflowHidden, setTabindex }
focus
{ focusTarget, focusTrigger, FocusTrap }
getElement
{ getElement }
moveElement
{ moveElement }
transition
{ openTransition, closeTransition }
Ref #257