Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package exports and bundles #293

Merged
merged 4 commits into from Aug 9, 2020
Merged

Fix package exports and bundles #293

merged 4 commits into from Aug 9, 2020

Conversation

sebnitu
Copy link
Owner

@sebnitu sebnitu commented Aug 9, 2020

Problem

The way bundle and exports are being handled isn't very consistent or entirely coherent.

Solution

This PR attempts to be more logical about how Vrembem bundles and exports it's modules. It now correctly points the browser field in package.json to the bundled CommonJS (cjs) files and removes the main and module fields. Module consumption now treats the exports as follows:

Module Export type
@vrembem/checkbox default
@vrembem/dismissible default
@vrembem/drawer default
@vrembem/modal default
@vrembem/core named
vrembem named

@sebnitu sebnitu added the PR: fix label Aug 9, 2020
@sebnitu sebnitu merged commit b55cc70 into master Aug 9, 2020
@sebnitu sebnitu deleted the update-package-exports branch August 9, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant