New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modal focus trap feature #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
modal-focus-trap
branch
from
August 1, 2020 02:54
f83c276
to
2085030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a few outstanding accessibility issues with the current modal script.
Solution
This PR improve the modal component by introducing a focus trap feature. This ensures that while a modal is open, it's not possible to access the rest of the page using tab focus. In addition to this, a new enable and disable state management has been along with a main selector option which will make primary content areas within a page inaccessible while a modal is active. Lastly, to better improve the management of modals, a new move modal option and api was added to move all modals in a document to a specific location. This prevents a modal from inheriting the inaccessible state if it's originally within the main content area. The new modal behavior pattern is as follows:
esc
key or clicking outside the dialog.