New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output variables to better control base output #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds spacing and spacing-map vars to core which base and utility use as their default values.
sebnitu
force-pushed
the
base-output-control
branch
from
July 24, 2020 19:17
2be67bf
to
30fffad
Compare
sebnitu
force-pushed
the
base-output-control
branch
from
July 24, 2020 20:37
85ed4be
to
c80c671
Compare
sebnitu
force-pushed
the
base-output-control
branch
from
July 24, 2020 21:36
a9011d9
to
4de490a
Compare
sebnitu
force-pushed
the
base-output-control
branch
from
July 24, 2020 23:48
2944e8b
to
16601a8
Compare
sebnitu
force-pushed
the
base-output-control
branch
from
July 25, 2020 00:20
7371c3b
to
f2ef550
Compare
sebnitu
force-pushed
the
base-output-control
branch
from
July 25, 2020 04:19
483ee4e
to
53b1522
Compare
sebnitu
force-pushed
the
base-output-control
branch
from
July 25, 2020 19:16
8102465
to
df204c3
Compare
sebnitu
force-pushed
the
base-output-control
branch
from
July 25, 2020 20:57
acb872d
to
63b41d9
Compare
sebnitu
force-pushed
the
base-output-control
branch
from
July 25, 2020 21:03
63b41d9
to
c51b9ca
Compare
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's currently no control over what gets output when
@vrembem/base
is included in a project.Solution
To better control the base output, this PR introduces the
$output
and$output-[module]
variables that take a boolean value and will either enable or disable a modules CSS output. Setting$output
will be passed to all other module output variables as their default option. This allows you to disable all modules and add only the ones you need vs having them all output by default and disable the ones you don't need.Examples
Additional changes
This PR also does the following:
spacing
into the base component$spacing
and$spacing-map
vars to corebase
andutility
components pass core spacing variables as their defaults for equivalent variablesscroll-box()
mixin