Refactor drawer breakpoint methods #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Drawer breakpoints are currently stored as an array in the returned api
mediaQueryLists
as HTML elements. This breaks the breakpoint queries in the instances where the DOM is updated via AJAX or other DOM manipulation tools such as React or LiveView.Solution
This PR refactors the way media query lists are saved by saving the drawer key instead of the HTML element. Now the HTML lookup is done using the key after a breakpoint is matched and filtered.