Skip to content

Commit

Permalink
Limit clap to < 3.2 to avoid pointless deprecation warnings
Browse files Browse the repository at this point in the history 
clap >= 3.2 adds no value, so let them figure out what they want first.
This sounds like change for the sake of change.

See also clap-rs/clap#3822
  • Loading branch information
@sebastinas
sebastinas committed Jun 14, 2022
1 parent bcca9ae commit fc8765f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Expand Up @@ -17,7 +17,7 @@ members = ["assorted-debian-utils"]
anyhow = "1.0"
assorted-debian-utils = { version = "0.5", path = "assorted-debian-utils" }
chrono = "0.4"
clap = { version = "3", features = ["derive", "unicode", "wrap_help"] }
clap = { version = "3,<3.2", features = ["derive", "unicode", "wrap_help"] }

This comment has been minimized.

Sign in to view

Copy link
@epage

epage Jun 15, 2022

This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.

btw is there a reason this project doesn't check-in the Cargo.lock? Generally, it is recommended to do so for programs and that would have prevented the unintended upgrade rather than needing to pin the dependency.
futures = "0.3"
futures-util = "0.3"
httpdate = "1.0"
Expand Down

1 comment on commit fc8765f

@sebastinas
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen the deprecation warnings after a local cargo update. Having Cargo.lock checked in would not have changed that.

Please sign in to comment.