Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash when test run in child process ends unexpectedly and --log-junit is used #5825

Conversation

kubawerlos
Copy link
Contributor

Fixes #5771

See commit messages.

@kubawerlos kubawerlos changed the base branch from main to 10.5 April 22, 2024 18:18
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (9d1c41f) to head (705faa4).

Additional details and impacted files
@@             Coverage Diff              @@
##               10.5    #5825      +/-   ##
============================================
+ Coverage     90.28%   90.31%   +0.03%     
- Complexity     6439     6440       +1     
============================================
  Files           679      679              
  Lines         19540    19540              
============================================
+ Hits          17642    17648       +6     
+ Misses         1898     1892       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kubawerlos kubawerlos changed the title Do not crash when test run in child process ends unexpectedly and --log-junit` is used Do not crash when test run in child process ends unexpectedly and --log-junit is used Apr 22, 2024
@kubawerlos kubawerlos marked this pull request as ready for review April 22, 2024 18:35
@sebastianbergmann sebastianbergmann added type/bug Something is broken feature/process-isolation Issues related to running tests in separate PHP processes feature/logging Issues related to logging test results version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11 labels Apr 23, 2024
@sebastianbergmann
Copy link
Owner

Merged manually, thanks!

@kubawerlos kubawerlos deleted the fix_RunInSeparateProcess_and_JunitXmlLogger branch April 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/logging Issues related to logging test results feature/process-isolation Issues related to running tests in separate PHP processes type/bug Something is broken version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnit XML logger may crash when test that is run in separate process exits unexpectedly
2 participants