Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shortenedRecursiveExport() for data-providers #5774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 28, 2024

I just realized we already have a shortenedRecursiveExport version of the exporter, we just need to use

so instead of sebastianbergmann/exporter#55 we could just do this single line change

tested this change on roave/BetterReflection:

phpunit 11.0.8

Time: 01:21.576, Memory: 3.79 GB

OK, but some tests were skipped!
Tests: 10383, Assertions: 65007, Skipped: 7.

this PR:

Time: 00:20.042, Memory: 1.04 GB

OK, but some tests were skipped!
Tests: 10383, Assertions: 65007, Skipped: 7.

maybe I did not yet understand that you actually try to make this type of exporter configurable via #5773 ?

@staabm staabm marked this pull request as ready for review March 28, 2024 13:46
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (c6aae09) to head (1051f02).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5774   +/-   ##
=========================================
  Coverage     90.17%   90.17%           
  Complexity     6582     6582           
=========================================
  Files           693      693           
  Lines         19940    19941    +1     
=========================================
+ Hits          17980    17981    +1     
  Misses         1960     1960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staabm
Copy link
Contributor Author

staabm commented Apr 5, 2024

@sebastianbergmann does this PR depend on the exporter object PR or can it land independently for 11.x ?

@sebastianbergmann
Copy link
Owner

Not completely exporting data provided by data providers is a BC break and should be opt-in. I am still not sure, though, what the right course of action is here "in the big picture". I hope to find time soon to think about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants