Remove Test\AssertionFailed
and Test\AssertionSucceeded
events
#5604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced the event system with PHPUnit 10, we thought it would be nice to emit events,
Test\AssertionFailed
andTest\AssertionSucceeded
, after an assertion is performed.While PHPUnit itself does not need these events, it does not subscribe to them itself, they have been a constant source of problems: #5183, #5184, #5261, #5510, #5515, #5524, #5539.
The workarounds that were implemented do not seem to always yield the desired effect and, moreover, make the event system's implementation more complicated than it should be.
I therefore propose to remove these events ASAP, in PHPUnit 11. As far as I know, none of the widely used extensions for PHPUnit subscribe to these events, so this removal should not be a problem.