Fixed #5230: @runClassInSeparateProcess has the same effect as @runTestsInSeparateProcesses #5233

WalterWoshid · 2023-02-22T22:17:46Z

Did some refactoring and now it works :)

I also did some testing for my personal use case and it works!!!

codecov · 2023-02-23T05:32:24Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a6319b7) 89.80% compared to head (bdf2488) 81.34%.

❗ Current head bdf2488 differs from pull request most recent head 546f158. Consider uploading reports for the commit 546f158 to get more accurate results

Files	Patch %	Lines
src/Util/PHP/AbstractPhpProcess.php	79.31%	6 Missing ⚠️
src/Framework/TestSuite.php	94.73%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               10.5    #5233      +/-   ##
============================================
- Coverage     89.80%   81.34%   -8.47%     
+ Complexity     6420     5866     -554     
============================================
  Files           680      629      -51     
  Lines         20389    18564    -1825     
============================================
- Hits          18311    15100    -3211     
- Misses         2078     3464    +1386

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WalterWoshid · 2023-02-27T21:29:16Z

@ob_end_clean(); in the template sometimes logs failed to delete buffer. No buffer to delete to the console. Not sure what it's needed for, maybe someone can look into it and place it at the right position

sebastianbergmann · 2024-01-13T13:44:53Z

I am sorry that I was not able to review this pull request sooner. Can you please explain on a conceptual what was wrong and how you fixed it? Thanks!

This pull request has conflicts that must be resolved. It also targets the main branch. It should target the 10.5 branch now (it should have targetted the 10.1 branch when it was created).

WalterWoshid · 2024-01-16T09:13:46Z

Hi @sebastianbergmann,

as far as I remember, the logic for @runClassInSeparateProcess and @runTestsInSeparateProcesses was placed in the same loop for running tests which made it actually impossible to run the class in a separate process, which is why I moved the @runClassInSeparateProcess logic from TestCase to TestSuite. If you'd like, I can resolve the merge conflicts :)

sebastianbergmann · 2024-01-16T09:14:33Z

If you'd like, I can resolve the merge conflicts :)

Yes, please. Thanks!

WalterWoshid · 2024-01-16T14:40:18Z

Done :)

WalterWoshid · 2024-01-16T14:58:54Z

Sorry for the multiple actions, forgot the guidelines, then the type checking.

sebastianbergmann · 2024-01-16T14:59:59Z

Sorry for the multiple actions, forgot the guidelines, then the type checking.

No worries, I don't mind clicking that button ;)

WalterWoshid · 2024-01-16T15:06:57Z

No worries, I don't mind clicking that button ;)

Good, because I changed the wrong variable and didn't check the tests again x(

Should be good now 👌

sebastianbergmann · 2024-01-16T15:36:05Z

Can you have a look into why the tests fail on PHP 8.3 and PHP 8.4? Thanks!

sebastianbergmann · 2024-01-17T06:32:20Z

src/Util/PHP/Template/TestCaseMethod.tpl

@@ -16,7 +16,7 @@ if (!defined('STDOUT')) {

 {iniSettings}
 ini_set('display_errors', 'stderr');
-set_include_path('{include_path}');
+set_include_path(unserialize('{include_path}'));


Why are serialize() / unserialize() now used for the include_path?

sebastianbergmann · 2024-01-17T06:32:38Z

src/Util/PHP/Template/TestCaseMethod.tpl

@@ -50,7 +50,7 @@ function __phpunit_run_isolated_test()

    $test = new {className}('{methodName}');

-    $test->setData('{dataName}', unserialize('{data}'));
+    $test->setData(unserialize('{dataName}'), unserialize('{data}'));


Why are serialize() / unserialize() now used for the name of a data set?

WalterWoshid · 2024-01-17T11:50:08Z

Yes, I'll have a look at it :)

sebastianbergmann · 2024-02-08T08:11:12Z

Yes, I'll have a look at it :)

Any update on this? Thanks!

sebastianbergmann · 2024-03-15T12:46:57Z

Yes, I'll have a look at it :)

@WalterWoshid Any update on this? Thanks!

staabm · 2024-03-16T06:56:53Z

src/Util/PHP/Template/TestCaseClass.tpl

+    $fileContents = '';
+
+    foreach ($tests as $test) {
+        $fileContents .= serialize(


I wonder why/whether it works to concat serialized strings together?

https://3v4l.org/t1ghY

staabm · 2024-04-18T13:33:06Z

@WalterWoshid do you have plans to finish this PR?

WalterWoshid changed the title ~~Fixed #5230~~ Fixed #5230: @runClassInSeparateProcess has the same effect as @runTestsInSeparateProcesses Feb 22, 2023

This was referenced Feb 23, 2023

@runClassInSeparateProcess has the same effect as @runTestsInSeparateProcesses #3258

Closed

Run a class in separate process. #2591

Closed

sebastianbergmann force-pushed the main branch 3 times, most recently from 08dc555 to 63591f3 Compare December 23, 2023 09:32

WalterWoshid changed the base branch from main to 10.5 January 16, 2024 14:37

WalterWoshid force-pushed the main branch from bdf2488 to 2472443 Compare January 16, 2024 14:38

WalterWoshid force-pushed the main branch 2 times, most recently from b94977a to 31730ec Compare January 16, 2024 14:57

Fix sebastianbergmann#5230

546f158

WalterWoshid force-pushed the main branch from 31730ec to 546f158 Compare January 16, 2024 15:05

sebastianbergmann reviewed Jan 17, 2024

View reviewed changes

staabm reviewed Mar 16, 2024

View reviewed changes

sebastianbergmann mentioned this pull request Apr 14, 2024

POC: lightweight subprocess isolation via pcntl_fork() #5751

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed #5230: @runClassInSeparateProcess has the same effect as @runTestsInSeparateProcesses #5233

Fixed #5230: @runClassInSeparateProcess has the same effect as @runTestsInSeparateProcesses #5233

WalterWoshid commented Feb 22, 2023 •

edited

codecov bot commented Feb 23, 2023 •

edited

WalterWoshid commented Feb 27, 2023

sebastianbergmann commented Jan 13, 2024

WalterWoshid commented Jan 16, 2024

sebastianbergmann commented Jan 16, 2024

WalterWoshid commented Jan 16, 2024

WalterWoshid commented Jan 16, 2024

sebastianbergmann commented Jan 16, 2024

WalterWoshid commented Jan 16, 2024

sebastianbergmann commented Jan 16, 2024

sebastianbergmann Jan 17, 2024

sebastianbergmann Jan 17, 2024

WalterWoshid commented Jan 17, 2024

sebastianbergmann commented Feb 8, 2024

sebastianbergmann commented Mar 15, 2024

staabm Mar 16, 2024

staabm commented Apr 18, 2024

Fixed #5230: @runClassInSeparateProcess has the same effect as @runTestsInSeparateProcesses #5233

Are you sure you want to change the base?

Fixed #5230: @runClassInSeparateProcess has the same effect as @runTestsInSeparateProcesses #5233

Conversation

WalterWoshid commented Feb 22, 2023 • edited

codecov bot commented Feb 23, 2023 • edited

Codecov Report

WalterWoshid commented Feb 27, 2023

sebastianbergmann commented Jan 13, 2024

WalterWoshid commented Jan 16, 2024

sebastianbergmann commented Jan 16, 2024

WalterWoshid commented Jan 16, 2024

WalterWoshid commented Jan 16, 2024

sebastianbergmann commented Jan 16, 2024

WalterWoshid commented Jan 16, 2024

sebastianbergmann commented Jan 16, 2024

sebastianbergmann Jan 17, 2024

Choose a reason for hiding this comment

sebastianbergmann Jan 17, 2024

Choose a reason for hiding this comment

WalterWoshid commented Jan 17, 2024

sebastianbergmann commented Feb 8, 2024

sebastianbergmann commented Mar 15, 2024

staabm Mar 16, 2024

Choose a reason for hiding this comment

staabm commented Apr 18, 2024

WalterWoshid commented Feb 22, 2023 •

edited

codecov bot commented Feb 23, 2023 •

edited