PHP error instead of PHPUnit error when trying to create test double for read-only class #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann
changed the title
readonly class
sebastianbergmann
changed the title
readonly class
|
Cherry-picked into |
|
Is there any reason behind this? Or any way to bypass this? Because this seems to me sofar very self-judgemental, leading to have a lot of boilerplate code just to have something tested. Also should I mention, that this was pretty much breaking change? |
|
@sebastianbergmann hello, Sebastian. Can you share your thoughts about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
According to new changes delivered in PHP 8.2, we cannot mock
readonlyclasses likefinalorenumby extending them.See reference: https://github.com/php/php-src/blob/7850c103894c50c4af4c2632c5ab60480a0fbdd3/Zend/tests/readonly_classes/readonly_class_inheritance_error1.phpt
Or shall we to add
readonlykeyword into generated mocked class to skip Runtime exception from PHP like: https://github.com/php/php-src/blob/7850c103894c50c4af4c2632c5ab60480a0fbdd3/Zend/tests/readonly_classes/readonly_class_inheritance_success.phpt