Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass null to ReflectionClass::getMethods() #5026

Merged
merged 1 commit into from Jul 29, 2022
Merged

Do not pass null to ReflectionClass::getMethods() #5026

merged 1 commit into from Jul 29, 2022

Conversation

erdemkose
Copy link

@erdemkose erdemkose commented Jul 29, 2022

Fixes #5016

PHP <7.2.18 and PHP <7.3.5 throw error when null is passed to ReflectionClass::getMethods() when strict_types is enabled.

@erdemkose erdemkose changed the base branch from main to 8.5 July 29, 2022 09:03
@sebastianbergmann sebastianbergmann added the type/change-in-php-requires-adaptation A change in PHP requires a change in PHPUnit label Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #5026 (b276edb) into 8.5 (9edbd2e) will increase coverage by 81.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             8.5    #5026       +/-   ##
==========================================
+ Coverage       0   81.94%   +81.94%     
- Complexity     0     5701     +5701     
==========================================
  Files          0      588      +588     
  Lines          0    14945    +14945     
==========================================
+ Hits           0    12246    +12246     
- Misses         0     2699     +2699     
Impacted Files Coverage Δ
src/Util/Reflection.php 100.00% <100.00%> (ø)
src/TextUI/Configuration/TestSuiteBuilder.php 100.00% <0.00%> (ø)
...ct/Exception/MethodCannotBeConfiguredException.php 0.00% <0.00%> (ø)
src/Event/TypeMap.php 54.54% <0.00%> (ø)
src/Metadata/PreserveGlobalState.php 100.00% <0.00%> (ø)
...rc/TextUI/Command/Commands/VersionCheckCommand.php 0.00% <0.00%> (ø)
src/Metadata/TestDox.php 100.00% <0.00%> (ø)
...ictAboutResourceUsageDuringSmallTestsAttribute.php 75.00% <0.00%> (ø)
src/Event/Value/TestData/TestDataCollection.php 65.21% <0.00%> (ø)
...ner/TestResult/Subscriber/TestFailedSubscriber.php 100.00% <0.00%> (ø)
... and 579 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sebastianbergmann sebastianbergmann merged commit 78493ab into sebastianbergmann:8.5 Jul 29, 2022
@erdemkose erdemkose deleted the fix-reflectionclass-getmethods-null branch July 29, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/change-in-php-requires-adaptation A change in PHP requires a change in PHPUnit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants