Fix memory leak in ExceptionWrapper #5012
Conversation
| @@ -109,14 +116,23 @@ public function getOriginalException(): ?Throwable | |||
| */ | |||
| private function originalException(Throwable $exceptionToStore = null): ?Throwable | |||
| { | |||
| static $originalExceptions; | |||
| // drop once PHP 7.3 support is removed | |||
| if (PHP_VERSION_ID < 70400) { | |||
There was a problem hiding this comment.
drop this code when merging to phpunit 10.x, but fix should target 9.5.x at least/latest stable
Codecov Report
@@ Coverage Diff @@
## 9.5 #5012 +/- ##
============================================
- Coverage 83.82% 83.79% -0.03%
- Complexity 4615 4618 +3
============================================
Files 272 272
Lines 11470 11474 +4
============================================
Hits 9615 9615
- Misses 1855 1859 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I have updated the PR description to understand the real issue better. Please merge this fix into at least phpunit 9.5. For next major release, is there any reason to not drop |
The |
Thank you ❤️ To fix the memory leaks in phpunit 9.5, can this PR be merged into 9.5.x branch? No BC break should be involved. |
sebastianbergmann
added
the
type/performance
Currently
ExceptionWrapperstores the original exception forever and prevents it to be GCed.This is causing not only memory to grow/leak, but also if the original exception has a reference to an object, the object is not released as well. Such scenario is not uncommon, as exception stack trace/frame can contain object arguments.
In consequence when the unreleased object is a some limited resource like DB connection, with a lot of wrapped/unreleased exceptions, the resource can be exhausted by a few failing tests making the other tests fail because of them.
This fix maintains the shallow backtrace as WeakReference property is not expanded during backtrace dump.
No BC break introduced.