allow suite to have exclude in any order with directory and file

[drealecs]

After upgrading from 6.5 to 7.5, few warning was visible for phpunit.xml schema validation each time phpunit was run.

  - Element 'directory': This element is not expected. Expected is ( exclude ).

and

  - Element 'file': This element is not expected. Expected is ( exclude ).

Having exclude tags interline with directory or file helps keeping things organized in a suite. Example:

<testsuite name="integration-without-db">
    <directory>test-integration/lib/Marketplace</directory>
    <exclude>test-integration/lib/Marketplace/WebService</exclude>

    <directory>test-integration/lib/Merchant</directory>
    
    <directory>test-integration/lib/MerchantToken</directory>
    <exclude>test-integration/lib/MerchantToken/MerchantTokenApiTest.php</exclude>

    <file>test-integration/lib/AdminIntegrationTest.php</file>
</testsuite>

[drealecs]

This can be rebased/cherry-picked for 8.5 branch as well for schema definition change. Let me know how you want to proceed.

[sebastianbergmann]

Please send this against 8.5. Thanks!

[drealecs]

Initial issue #3248 was fixed for any directory/file arrangements in general and also for exclude usage in filter>whitelist

[drealecs]

Please send this against 8.5. Thanks!

Done.
Opened a separate MR for the second commit that was initially included here, a very small optimization that I noticed when reading code to make sure the order is definitely not relevant: #4959

[codecov]

Codecov Report

Merging #4958 (6cf9445) into 8.5 (690d0c7) will increase coverage by 83.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             8.5    #4958       +/-   ##
==========================================
+ Coverage       0   83.96%   +83.96%     
- Complexity     0     4610     +4610     
==========================================
  Files          0      272      +272     
  Lines          0    11464    +11464     
==========================================
+ Hits           0     9626     +9626     
- Misses         0     1838     +1838     

Impacted Files	Coverage Δ
src/Framework/MockObject/ConfigurableMethod.php	72.72% <0.00%> (ø)
src/Util/PHP/AbstractPhpProcess.php	74.07% <0.00%> (ø)
...ect/Exception/MethodNameNotConfiguredException.php	0.00% <0.00%> (ø)
...ation/Migration/Migrations/CoveragePhpToReport.php	100.00% <0.00%> (ø)
...rc/Framework/Constraint/Operator/UnaryOperator.php	94.28% <0.00%> (ø)
src/Runner/Version.php	84.61% <0.00%> (ø)
src/Util/Annotation/Registry.php	100.00% <0.00%> (ø)
...ct/Exception/MethodCannotBeConfiguredException.php	0.00% <0.00%> (ø)
src/TextUI/XmlConfiguration/Logging/Text.php	100.00% <0.00%> (ø)
.../TextUI/XmlConfiguration/Group/GroupCollection.php	73.33% <0.00%> (ø)
... and 262 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more