Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Configure fixer to remove redundant parentheses #4915

Closed
wants to merge 3 commits into from

Conversation

jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Mar 7, 2022

Update PHP-CS-Fixer and enable a new_with_braces fixer according to this and this comments.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #4915 (30e7f82) into master (e6ac90d) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4915   +/-   ##
=========================================
  Coverage     83.85%   83.85%           
  Complexity     5726     5726           
=========================================
  Files           548      548           
  Lines         14868    14868           
=========================================
  Hits          12467    12467           
  Misses         2401     2401           
Impacted Files Coverage Δ
src/TextUI/Configuration/Configuration.php 73.92% <0.00%> (ø)
src/Event/Emitter/DispatchingEmitter.php 94.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ac90d...30e7f82. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Cherry-picked into 8.5 and merged to 9.5 and master from there. Thanks!

@jrmajor jrmajor deleted the new-parentheses branch March 9, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants