Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deprecation information #4865

Closed
wants to merge 1 commit into from
Closed

Conversation

dbu
Copy link

@dbu dbu commented Jan 15, 2022

Following the discussion in #3390

Imho there is no use in having @deprecated annotation if the new system is not available, as people can not avoid using this interface. And to my understanding, for version 8 and 9, implementing this interface is the way to go.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

@dbu
Copy link
Author

dbu commented Jan 15, 2022

that was my understanding of the discussion in #3390.

do you not want to address the problem that people are mislead by deprecation notices and try to migrate to a thing that is not fully working and will be replaced in phpunit 10 anyways? or did you have a different solution in mind?

@sebastianbergmann
Copy link
Owner

I hopefully addressed this in 9b5a2e5 just now. Thank you for bringing this to my attention again.

@dbu dbu deleted the patch-1 branch January 15, 2022 09:44
@dbu
Copy link
Author

dbu commented Jan 15, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants