Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to optional array key when using debug_backtrace() function #4857

Merged
merged 1 commit into from Jan 14, 2022
Merged

Fix access to optional array key when using debug_backtrace() function #4857

merged 1 commit into from Jan 14, 2022

Conversation

ste93cry
Copy link
Contributor

@ste93cry ste93cry commented Jan 8, 2022

The class, file and line array keys are optional for a stacktrace frame, so to silence PHPStan when the signature of the debug_backtrace() function will be narrowed down to an array shape with optional keys these little fixes are needed

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #4857 (da46b3f) into 8.5 (f085bc8) will increase coverage by 84.12%.
The diff coverage is 82.29%.

❗ Current head da46b3f differs from pull request most recent head d511c83. Consider uploading reports for the commit d511c83 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             8.5    #4857       +/-   ##
==========================================
+ Coverage       0   84.12%   +84.12%     
- Complexity     0     5773     +5773     
==========================================
  Files          0      549      +549     
  Lines          0    16533    +16533     
==========================================
+ Hits           0    13909    +13909     
- Misses         0     2624     +2624     
Impacted Files Coverage Δ
src/Framework/Constraint/Boolean/IsFalse.php 100.00% <ø> (ø)
src/Framework/Constraint/Boolean/IsTrue.php 100.00% <ø> (ø)
src/Framework/Constraint/Callback.php 100.00% <ø> (ø)
...c/Framework/Constraint/Cardinality/GreaterThan.php 100.00% <ø> (ø)
src/Framework/Constraint/Cardinality/IsEmpty.php 100.00% <ø> (ø)
src/Framework/Constraint/Cardinality/LessThan.php 100.00% <ø> (ø)
src/Framework/Constraint/Cardinality/SameSize.php 100.00% <ø> (ø)
src/Framework/Constraint/Exception/Exception.php 100.00% <ø> (ø)
...c/Framework/Constraint/Exception/ExceptionCode.php 100.00% <ø> (ø)
...ramework/Constraint/Exception/ExceptionMessage.php 100.00% <ø> (ø)
... and 612 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f085bc8...d511c83. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 6ac6234 into sebastianbergmann:8.5 Jan 14, 2022
@ste93cry
Copy link
Contributor Author

@sebastianbergmann sorry to be "that guy", but since this PR is required to let the build in phpstan/phpstan-src pass, do you have any ETA on when the next 9.5 version containing it will be released?

@sebastianbergmann
Copy link
Owner

I just released PHPUnit 9.5.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants