Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4591 do not treat warnings as error in teamcity #4623

Closed
wants to merge 3 commits into from
Closed

#4591 do not treat warnings as error in teamcity #4623

wants to merge 3 commits into from

Conversation

tlamy
Copy link

@tlamy tlamy commented Mar 16, 2021

As suggested by Jetbrains in https://youtrack.jetbrains.com/issue/WI-57958 , just write warnings to stdout in the teamcity logger. This fixes #4591.
Should I create a PR for 8.5.x, as it may be worth having it there also?

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #4623 (73be161) into master (6eb1bc9) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4623      +/-   ##
============================================
+ Coverage     83.30%   83.34%   +0.03%     
  Complexity     4525     4525              
============================================
  Files           292      292              
  Lines         11934    11929       -5     
============================================
  Hits           9942     9942              
+ Misses         1992     1987       -5     
Impacted Files Coverage Δ Complexity Δ
src/Util/Log/TeamCity.php 59.28% <0.00%> (+2.04%) 56.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb1bc9...73be161. Read the comment docs.

@tlamy tlamy changed the base branch from master to 9.5 March 17, 2021 06:57
@tlamy tlamy changed the base branch from 9.5 to master March 17, 2021 06:58
@sebastianbergmann
Copy link
Owner

Cherry-picked into 8.5 and merged to 9.5 and master from there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamCity logger logs warnings as test failures
2 participants