JUnit: report Risky test consistently as an error

[Slamdunk]

Close #3937

[sebastianbergmann]

Have you seen #3913 (comment)? Is your change compatible with Jenkins, etc.? In other words: are you sure this has no unintended side effects?

[Slamdunk]

Are you sure this has no unintended side effects?

If you are asking me to bet my kids' lifes, no.
But I'm altering only the content of the XML tag, which is by that XSD definition a free string.
Until #4321 gets implemented, this PR is essential for ParaTest because, as of yet, we get zero information about the failure otherwise:

There were 3 errors:

1) Risky Test

2) ParaTest\Tests\fixtures\failing_tests\UnitTestWithErrorTest::testTruth
RuntimeException: Error!!!

./paratest/test/fixtures/failing_tests/UnitTestWithErrorTest.php:21

3) Risky Test

May I ask you how to fix the errors reported in CI?

-    <testcase name="testWarning" class="PHPUnit\SelfTest\Basic\StatusTest" classname="PHPUnit.SelfTest.Basic.StatusTest" file="%s%eStatusTest.php" line="%d" assertions="0" time="%f">
+    <testcase name="testWarning" class="PHPUnit\SelfTest\Basic\StatusTest" classname="PHPUnit.SelfTest.Basic.StatusTest" file="/home/runner/work/phpunit/phpunit/tests/basic/unit/StatusTest.php" line="57" assertions="0" time="0.000091">

I have honestly no idea what's going on in these test results 😕

[sebastianbergmann]

If you are asking me to bet my kids' lifes, no.
But I'm altering only the content of the XML tag, which is by that XSD definition a free string.

Okay.

I have honestly no idea what's going on in these test results 😕

Me neither, I'll have a look ASAP.

[sebastianbergmann]

sigh, the tests are still failing on Windows.