Fix: Make tests failing on Windows portable or skip them

[localheinz]

This PR

• skips two tests failing on window-latest
• attempts to make a few tests failing on window-latest portable

Related to #4333.
Follows #4335.

[codecov]

Codecov Report

Merging #4343 into 9.2 will increase coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                9.2    #4343      +/-   ##
============================================
+ Coverage     84.27%   84.71%   +0.44%     
- Complexity     4528     4529       +1     
============================================
  Files           218      218              
  Lines         11107    11791     +684     
============================================
+ Hits           9360     9989     +629     
- Misses         1747     1802      +55     

Impacted Files	Coverage Δ	Complexity Δ
src/Framework/SkippedTestCase.php	90.90% <0.00%> (-9.10%)	4.00% <0.00%> (ø%)
src/Framework/IncompleteTestCase.php	90.90% <0.00%> (-9.10%)	4.00% <0.00%> (ø%)
src/Runner/NullTestResultCache.php	66.66% <0.00%> (-8.34%)	6.00% <0.00%> (ø%)
src/TextUI/Configuration/Registry.php	83.33% <0.00%> (-6.67%)	6.00% <0.00%> (ø%)
src/Framework/MockObject/Stub/ReturnArgument.php	66.66% <0.00%> (-4.77%)	4.00% <0.00%> (ø%)
src/Framework/Constraint/JsonMatches.php	96.77% <0.00%> (-3.23%)	9.00% <0.00%> (ø%)
src/Util/TestDox/HtmlResultPrinter.php	92.00% <0.00%> (-2.74%)	8.00% <0.00%> (ø%)
src/Util/TestDox/ResultPrinter.php	57.14% <0.00%> (-1.48%)	39.00% <0.00%> (ø%)
src/Util/TestDox/TextResultPrinter.php	78.57% <0.00%> (-1.43%)	5.00% <0.00%> (ø%)
src/Util/Xml.php	84.74% <0.00%> (-0.73%)	52.00% <0.00%> (ø%)
... and 168 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d774ce...5250144. Read the comment docs.

[sebastianbergmann]

Please rebase against 9.2 so that f57379c is there. This hopefully solves the TypeError issue.

[localheinz]

@sebastianbergmann

Tests fail with

PHP Warning:  file_get_contents(D:\a\phpunit\phpunit\tests\end-to-end\abstract-test-class.coverage): Failed to open stream: No such file or directory in D:\a\phpunit\phpunit\src\Runner\PhptTestCase.php on line 600
PHP Warning:  file_get_contents(D:\a\phpunit\phpunit\tests\end-to-end\assertion.coverage): Failed to open stream: No such file or directory in D:\a\phpunit\phpunit\src\Runner\PhptTestCase.php on line 600
PHP Warning:  file_get_contents(D:\a\phpunit\phpunit\tests\end-to-end\cli\bootstrap-not-found.coverage): Failed to open stream: No such file or directory in D:\a\phpunit\phpunit\src\Runner\PhptTestCase.php on line 600
...

following f57379c, see ❌.

Should we check whether the files exist? Should they exist?

[localheinz]

@sebastianbergmann

I have fixed at least a few the tests failing on Windows - what do you think about merging this, and then we can take a look at the rest?

As far as I can see, the builds for

• master
• 9.2

are all failing for windows-latest at the moment.

[sebastianbergmann]

Errors: 4, Failures: 281 -- that's a lot.

@cmb69 Do you have an idea why so many tests fail with PHP 8 on Windows? Thanks!

[cmb69]

Enclosing the first argument to proc_open() in quotes is likely to cause issues, because this is now done by proc_open() (see php/php-src@9ca449e).

Form a quick look, it seems that several other (most?) test failures are caused by segfaults. :(

[localheinz]

Thank you, @cmb69 and @sebastianbergmann!

[sebastianbergmann]

Thank you, @cmb69. I took care of the proc_open() change in 9e3958d.