Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InvocationMocker part of the public API #4310

Merged
merged 1 commit into from Jun 24, 2020
Merged

Make InvocationMocker part of the public API #4310

merged 1 commit into from Jun 24, 2020

Conversation

morozov
Copy link
Contributor

@morozov morozov commented Jun 21, 2020

The InvocationMocker interface is exposed to the userland via MockObject::expects():

public function expects(InvocationOrder $invocationRule): BuilderInvocationMocker;

According to #3236, the @internal annotation should be removed.

Fixes #4309.

@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #4310 into 8.5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                8.5    #4310   +/-   ##
=========================================
  Coverage     84.20%   84.20%           
  Complexity     3938     3938           
=========================================
  Files           154      154           
  Lines          9787     9787           
=========================================
  Hits           8241     8241           
  Misses         1546     1546           
Impacted Files Coverage Δ Complexity Δ
.../Framework/MockObject/Builder/InvocationMocker.php 93.54% <ø> (ø) 34.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809b4bf...baf9f9c. Read the comment docs.

@morozov
Copy link
Contributor Author

morozov commented Jul 18, 2020

@sebastianbergmann would it be possible to release this change in the 8.5 series? Thank you.

@sebastianbergmann
Copy link
Owner

AFAICS, the change is in the 8.5 branch. It will be part of the next PHPUnit 8.5 release.

@morozov
Copy link
Contributor Author

morozov commented Jul 19, 2020

Yeah. Is there ETA for it? Not that it’s urgent, I just saw a couple of 9.2 releases since this issue was resolved.

@sebastianbergmann
Copy link
Owner

Apart from this change, there is currently no substantial change in the 8.5 branch that would warrant a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants