Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable phpdoc_summary fixer #4294

Merged

Conversation

localheinz
Copy link
Collaborator

@localheinz localheinz commented Jun 15, 2020

This PR

  • enables the phpdoc_summary fixer
  • runs php-cs-fixer
  • sorts out a few issues manually

Slightly related to #3936.

πŸ’β€β™‚οΈ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/tree/v2.16.3#usage:

phpdoc_summary

PHPDoc summary should end in either a full stop, exclamation mark, or question mark.

@localheinz localheinz self-assigned this Jun 15, 2020
@localheinz localheinz changed the base branch from master to 8.5 June 15, 2020 15:31
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #4294 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4294      +/-   ##
============================================
- Coverage     84.67%   84.65%   -0.03%     
  Complexity     4551     4551              
============================================
  Files           257      218      -39     
  Lines         11428    11306     -122     
============================================
- Hits           9677     9571     -106     
+ Misses         1751     1735      -16     
Impacted Files Coverage Ξ” Complexity Ξ”
src/Framework/Constraint/Cardinality/IsEmpty.php 100.00% <ΓΈ> (ΓΈ) 7.00 <0.00> (ΓΈ)
src/Framework/Constraint/Constraint.php 100.00% <ΓΈ> (ΓΈ) 17.00 <0.00> (ΓΈ)
src/Framework/Constraint/Equality/IsEqual.php 100.00% <ΓΈ> (ΓΈ) 10.00 <0.00> (ΓΈ)
...work/Constraint/Equality/IsEqualCanonicalizing.php 62.96% <ΓΈ> (ΓΈ) 9.00 <0.00> (ΓΈ)
...mework/Constraint/Equality/IsEqualIgnoringCase.php 81.48% <ΓΈ> (ΓΈ) 9.00 <0.00> (ΓΈ)
...Framework/Constraint/Equality/IsEqualWithDelta.php 68.18% <ΓΈ> (ΓΈ) 7.00 <0.00> (ΓΈ)
src/Framework/Constraint/Exception/Exception.php 100.00% <ΓΈ> (ΓΈ) 6.00 <0.00> (ΓΈ)
...c/Framework/Constraint/Exception/ExceptionCode.php 100.00% <ΓΈ> (ΓΈ) 4.00 <0.00> (ΓΈ)
...ramework/Constraint/Exception/ExceptionMessage.php 100.00% <ΓΈ> (ΓΈ) 7.00 <0.00> (ΓΈ)
...nt/Exception/ExceptionMessageRegularExpression.php 100.00% <ΓΈ> (ΓΈ) 5.00 <0.00> (ΓΈ)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 7fc0e3c...dd2f324. Read the comment docs.

@localheinz localheinz requested review from epdenouden and sebastianbergmann and removed request for epdenouden June 15, 2020 15:38
@localheinz localheinz marked this pull request as ready for review June 15, 2020 15:39
@localheinz localheinz marked this pull request as draft June 15, 2020 15:44
@localheinz localheinz changed the base branch from 8.5 to master June 15, 2020 15:44
@localheinz localheinz marked this pull request as ready for review June 15, 2020 15:53
@sebastianbergmann sebastianbergmann merged commit 9d9c56c into sebastianbergmann:master Jun 15, 2020
@localheinz localheinz deleted the feature/phpdoc-summary branch June 15, 2020 15:55
@localheinz
Copy link
Collaborator Author

Thank you, @sebastianbergmann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants