-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude internal tests from composer dist packages #4151
Conversation
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. |
@sebastianbergmann I agree that the suggestion in this PR is a bit too much. Could you explain why you left out |
AFAIK, @remicollet and other downstream packagers rely on tests etc. being included in release tarballs. I would gladly add them to |
They can still have the tests by using prefer-source. That's not a valid argument to not change it. |
I think you are right. And I think that |
This has been discussed ad-nauseam. "prefer-source' is a composer option, so only for composer user. tests are part of the project so have to be part of the public tarball, like documentation, license, or any other file used by the project. Again THIS IS A COMPOSER ISSUE, not being able to manage file "roles" PHP is the only language in the world to NOT have any INSTALLER (and composer is not an installer, only a dependency manager). perl have cpan, Even the old PEAR was able to manage file "roles" BTW, using git snapshot instead of official tarball still possible This issue make all non-php developers laugh, so continue, in our strange configned world, always nice to have something to laugh about. |
@remicollet what is the difference between npm and composer? For me they do the same. |
"npm install foo" is able to install only needed scripts, without using any .gitattributes hack. |
See discussion for example symfony/symfony#33579
It was already done in phpunit in d99e588 but reverted because it also removed the changelog and license file by mistake.