Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize JSON values in failure message #4130

Merged

Conversation

localheinz
Copy link
Collaborator

This PR

  • uses canonicalized JSON values in failure messages

馃拋鈥嶁檪 This makes it easier to spot the actual difference when dealing with JSON structures that have a few more fields.

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憦 nice enhancement 馃憤

@sebastianbergmann sebastianbergmann added feature/assertion Issues related to assertions and expectations type/enhancement A new idea that should be implemented labels Mar 4, 2020
@sebastianbergmann sebastianbergmann added this to the PHPUnit 9.1 milestone Mar 4, 2020
@sebastianbergmann sebastianbergmann merged commit 9ffa5b1 into sebastianbergmann:master Mar 10, 2020
@sebastianbergmann sebastianbergmann changed the title Enhancement: Canonicalize JSON values in failure message Canonicalize JSON values in failure message Mar 10, 2020
@sebastianbergmann
Copy link
Owner

Please no "Enhancement: " prefix in issue titles. We have labels for that. Thanks!

@localheinz localheinz deleted the feature/canonicalize branch March 10, 2020 14:49
@localheinz
Copy link
Collaborator Author

Thank you, @OskarStark and @sebastianbergmann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/assertion Issues related to assertions and expectations type/enhancement A new idea that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants