Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning if trailing slash in path is omitted #3984

Merged
merged 3 commits into from Dec 10, 2019

Conversation

realFlowControl
Copy link
Sponsor Contributor

Fixes #3983 if the trailing slash in path is omitted

@sebastianbergmann
Copy link
Owner

Can you have a look at the test failures? Thanks!

@realFlowControl
Copy link
Sponsor Contributor Author

I am on it. Tricky, because it's working on my local machine ... ;-)

@realFlowControl
Copy link
Sponsor Contributor Author

This is a weird problem. There is a file named tests/end-to-end/regression/GitHub/3983.phpt and a directory with tests to this named tests/end-to-end/regression/GitHub/3983/. In my local setup, a call to phpunit tests/end-to-end/regression/GitHub/3983 will use the test files from the directory, but in the pipeline it will try to find a test class 3983 in the file 3983.phpt which does not exist.
I fixed this now by renaming the phpt file, but what would be the desired behavior in this case? Should phpunit use the file or the directory?

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #3984 into 8.5 will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.5    #3984      +/-   ##
============================================
- Coverage     84.89%   84.86%   -0.04%     
- Complexity     3919     3920       +1     
============================================
  Files           153      153              
  Lines         10092    10093       +1     
============================================
- Hits           8568     8565       -3     
- Misses         1524     1528       +4
Impacted Files Coverage Δ Complexity Δ
src/TextUI/Command.php 76.24% <100%> (+0.03%) 218 <0> (+1) ⬆️
src/Util/PHP/AbstractPhpProcess.php 71.97% <0%> (-2.55%) 43% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4e631...4a24834. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Weird indeed, but (hopefully) a problem for another day.

@sebastianbergmann sebastianbergmann merged commit 03cf9c4 into sebastianbergmann:8.5 Dec 10, 2019
@realFlowControl realFlowControl deleted the fix-3983 branch February 13, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants