Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export development-only files #3855

Closed

Conversation

oliverklee
Copy link
Sponsor Contributor

The files that are used for developing PHPUnit
(but not for developing with PHPUnit) should not be
exported.

This should reduce the size of the Composer packages
that are installed with the --prefer-dist option
(which is the default) considerably.

The files that are used for developing PHPUnit
(but not for developing _with_ PHPUnit) should not be
exported.

This should reduce the size of the Composer packages
that are installed with the `--prefer-dist` option
(which is the default) considerably.
@oliverklee
Copy link
Sponsor Contributor Author

To keep things simple, this 7.5 version also includes some files and directories have have been introduced in 8.3.

The files are ordered the same way they are ordered in PhpStorm.

@codecov
Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #3855 into 7.5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                7.5    #3855   +/-   ##
=========================================
  Coverage     83.62%   83.62%           
  Complexity     3651     3651           
=========================================
  Files           143      143           
  Lines          9743     9743           
=========================================
  Hits           8148     8148           
  Misses         1595     1595
Impacted Files Coverage Δ Complexity Δ
src/Runner/Version.php 66.66% <0%> (ø) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191e034...fc6a09b. Read the comment docs.

@kubawerlos
Copy link
Contributor

Can we have /.* export-ignore for all the dot-starting-files? The convention is that these files are internal and not to be released after all, right?

@sebastianbergmann
Copy link
Owner

I am reluctant to merge this as there were problems in the past when tests was ignored for export.

AFAIK, @remicollet relies on tests being exported. Maybe he can provide some insight?

@oliverklee
Copy link
Sponsor Contributor Author

Can we have /.* export-ignore for all the dot-starting-files?

I would be fine with that. @sebastianbergmann What do you think?

@oliverklee
Copy link
Sponsor Contributor Author

Symfony recently had this change, too:
symfony/yaml@79800cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants