Make epsilon for float comparison customizable - #3159 #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Sep 6, 2019
| @@ -55,10 +55,15 @@ public function __construct($value) | |||
| */ | |||
| public function evaluate($other, string $description = '', bool $returnResult = false) | |||
| { | |||
| $epsilon = self::EPSILON; | |||
| if (defined('CUSTOM_EPSILON')) { | |||
There was a problem hiding this comment.
What about defining EPSILON conditionally in a namespace, and always having it declared?
Basides that, while the global state is immutable, I'm not sure I like the approach. What alternatives (if any) do we have?
SebastianKull
force-pushed
the
feature/3159-isidentical-customizable-epsilon
branch
from
dbc06cc
to
df1b398
Compare
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. See https://github.com/sebastianbergmann/phpunit/issues/3159#issuecomment-528908608 for details. |
epdenouden
added
the
event/code-sprint/2019-09
SebastianKull
deleted the
feature/3159-isidentical-customizable-epsilon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it would be possible to make the epsilon from float comparison customizable.
see #3159