Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export constants values when mocking method #3802

Closed
wants to merge 1 commit into from
Closed

Export constants values when mocking method #3802

wants to merge 1 commit into from

Conversation

gleb-svitelskiy
Copy link
Contributor

Fix for issue #3801
Contributors should consider to change minimum supported PHP version

@sebastianbergmann
Copy link
Owner

What do you mean by "Contributors should consider to change minimum supported PHP version"?

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #3802 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3802      +/-   ##
===========================================
+ Coverage     82.49%   82.5%   +0.01%     
+ Complexity     3837    3833       -4     
===========================================
  Files           150     150              
  Lines         10157   10147      -10     
===========================================
- Hits           8379    8372       -7     
+ Misses         1778    1775       -3
Impacted Files Coverage Δ Complexity Δ
src/Framework/MockObject/MockMethod.php 91.19% <100%> (+1.25%) 47 <0> (-4) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c14d0f...9133872. Read the comment docs.

@gleb-svitelskiy
Copy link
Contributor Author

gleb-svitelskiy commented Aug 29, 2019

What do you mean by "Contributors should consider to change minimum supported PHP version"?

This problem because of PHP bug https://bugs.php.net/bug.php?id=76717. Fix was released in versions 7.2.17 and 7.3.4. But latest version of PHPUnit requires "php": "^7.2" in composer. And version_compare('7.2.0', PHP_VERSION, '>') in phpunit file. So it can be used on versions from 7.2.1 to 7.2.16, and from 7.3.0 to 7.3.3 where PHP bug #76717 still there.

gleb@svitelskiy:~$ docker run --rm php:7.2.16 php -r 'var_export(PHP_INT_MIN);echo "\n";'
-9223372036854775808
gleb@svitelskiy:~$ docker run --rm php:7.2.17 php -r 'var_export(PHP_INT_MIN);echo "\n";'
-9223372036854775807-1
gleb@svitelskiy:~$ docker run --rm php:7.3.3 php -r 'var_export(PHP_INT_MIN);echo "\n";'
-9223372036854775808
gleb@svitelskiy:~$ docker run --rm php:7.3.4 php -r 'var_export(PHP_INT_MIN);echo "\n";'
-9223372036854775807-1

@sebastianbergmann
Copy link
Owner

Merged manually, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants