Move ReflectionType::__toString() cases to getName()

[stronk7]

While this has become obvious in php74, because now a warning is
emitted, that function has been deprecated since php71 (without
warning), so it's perfectly ok/safe to apply for it in phpunit7 (that
officially supports php71-php73).

Plus, of course, this enables some projects, that cannot follow
phpunit support schema 100% all the time, to continue working
with phpunit7 and php74.

Our case, Moodle 3.8, to be released in November 2019, days before
the end of php71 support, will need to support php71 and also php74.
Having an unique phpunit helps a lot, and it seems achievable.

Then, in Moodle 3.9, to be released in May 2020, we'll upgrade
to phpunit8 because that will match 100% out php72 - php74.

So basically, in our May releases, we always match 100% phpunit's
php supported versions, but in our November releases, we usually
require an older phpunit to work with a newer php (that is not bad).

Back to results... this change in the 7.5 branch allows everything to continue working (unit tests pass) for php71 to php73... and improves a lot the php74 experience, going from

Tests: 2077, Assertions: 3620, Errors: 1, Failures: 39, Skipped: 10.

to

Tests: 2077, Assertions: 3620, Errors: 1, Skipped: 10.

(the remaining error, pre-existing, doesn't seem to affect us)

For your consideration, ciao :-)

[stronk7]

Thanks!

[driesvints]

@sebastianbergmann do you know in which exact release this fix is included? I can't find it in the changelogs.

[sebastianbergmann]

https://github.com/sebastianbergmann/phpunit/blob/7.5/ChangeLog-7.5.md#7515---2019-08-21 -> 7.5.14...7.5.15

[driesvints]

@sebastianbergmann ah okay. I was looking at which 8.x release had this because it seem to fail on 8.1.3: #3728

[sebastianbergmann]

8.2.5...8.3.0 :-)

[driesvints]

Thanks! 😄