Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in assertion and mock type definitions #3708

Closed
wants to merge 18 commits into from
Closed

Built-in assertion and mock type definitions #3708

wants to merge 18 commits into from

Commits on Jun 5, 2019

  1. Adding @vimeo/psalm-specific templated type declarations for the mock… 

    … API
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    910cf67 View commit details
    Browse the repository at this point in the history

  2. Added workaround to allow Psalm to recognize MockObject#method() calls

    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    764d671 View commit details
    Browse the repository at this point in the history

  3. Decorating Assert with @vimeo/psalm-specific type annotations

    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    ae6da69 View commit details
    Browse the repository at this point in the history

  4. Split assertion type-check tests into isolated test scenarios 

    Each file verifies that the type can be correctly inferred
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    d50a353 View commit details
    Browse the repository at this point in the history

  5. Added psalm.xml configuration file to check the happy-path static s… 

    …cenarios

This is a temporary file location, since the project has its own conventions
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    db2a042 View commit details
    Browse the repository at this point in the history

  6. Added static-analysis tests to CI runs

    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    7edbe46 View commit details
    Browse the repository at this point in the history

  7. Reverted BC brak: MockObject#method() now correctly detected by Psalm 

    Ref: #3708 (comment)
Ref: vimeo/psalm#1692
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    ce564bc View commit details
    Browse the repository at this point in the history

  8. Removed vimeo/psalm from require-dev: PHPUnit already has a scope… 

    …d phar

Ref: #3708 (comment)
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    a503a31 View commit details
    Browse the repository at this point in the history

  9. PropertyNotSetInConstructor cannot be avoided in TestCase child c… 

    …lasses

Suppressing the error here.
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    4a47a83 View commit details
    Browse the repository at this point in the history

  10. Disabling type declarations for trait mocking TestCase methods 

    Traits are no real types,  therefore we cannot support their usage
in templated types.
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    6b89215 View commit details
    Browse the repository at this point in the history

  11. Psalm must run against static analysis tests with totallyTyped="true"

    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    cde4a44 View commit details
    Browse the repository at this point in the history

  12. Added PHPStorm type meta-hints, allowing downstream intellisense on m… 

    …ocks
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    0d46ceb View commit details
    Browse the repository at this point in the history

  13. Corrected Assert::assertIs(Not)Scalar() type assertions 

    Incorrect docblock format was used, and incorrect return type was used in
the test scenario.
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    47f3ec0 View commit details
    Browse the repository at this point in the history

  14. Using objects/integers to verify assert(Not)Empty type assertions 

    This is a workaround to not require vimeo/psalm#1743
to be fixed first
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    ed1cc0d View commit details
    Browse the repository at this point in the history

  15. Failures should be allowed on PHP nightly 

    `master` was being used instead, but no such version is present in the build
matrix.
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    a2514b4 View commit details
    Browse the repository at this point in the history

  16. Corrected type-check errors detected by Psalm run over the whole code… 

    …base
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    a967a09 View commit details
    Browse the repository at this point in the history

  17. Excluded static-analysis directory from CS-fixer paths 

    Annotations such as `@return numeric` are not recognized by this tooling,
so for now this test suite is off-limits for `php-cs-fixer`.
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    a330d23 View commit details
    Browse the repository at this point in the history

  18. TestCase#expectException() requires a class-string<\Throwable> 

    Ref: #3708 (comment)
    @Ocramius
    Ocramius committed Jun 5, 2019
    Copy the full SHA
    c7cfb86 View commit details
    Browse the repository at this point in the history