Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mark field and methods related to deprecated TestListener as deprecated #3667

Merged

Conversation

localheinz
Copy link
Collaborator

This PR

  • marks fields and methods on TestResult that are related to the deprecated TestListener as deprecated (and ignores methods in regard to code coverage)

Related to #3388.

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #3667 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3667      +/-   ##
============================================
+ Coverage     83.03%   83.05%   +0.02%     
+ Complexity     3721     3714       -7     
============================================
  Files           143      143              
  Lines          9778     9768      -10     
============================================
- Hits           8119     8113       -6     
+ Misses         1659     1655       -4
Impacted Files Coverage Δ Complexity Δ
src/Framework/TestResult.php 74.42% <ø> (+0.35%) 162 <0> (-7) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e8d3a...7fd70bc. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit f95d7ce into sebastianbergmann:master Apr 29, 2019
@localheinz localheinz deleted the fix/test-listener branch April 29, 2019 05:44
@localheinz
Copy link
Collaborator Author

Thank you, @sebastianbergmann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants