Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use symfony/process to run isolated tests #3563

Closed
wants to merge 1 commit into from

Conversation

rpkamp
Copy link
Contributor

@rpkamp rpkamp commented Mar 15, 2019

Replaces #3117 - I had deleted the fork for that PR, so I can't push to it anymore

Fixes #1342

Can only be merged once #2015 lands

@ADmad
Copy link

ADmad commented Aug 2, 2019

I just hope this doesn't cause version conflict issues with libs/projects/apps already having symfony/process as dependency.

@rpkamp
Copy link
Contributor Author

rpkamp commented Aug 2, 2019

That's why it will be included in the scoped phar file, once that's there :)

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

@rpkamp
Copy link
Contributor Author

rpkamp commented Mar 31, 2020

Might I ask why?

@rpkamp
Copy link
Contributor Author

rpkamp commented Mar 31, 2020

Ah, just saw this comment - never mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace PHP process isolation code with Symfony Process component
3 participants