Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resolveDependencies=true the default for phpunit.xml #3540

Closed
wants to merge 1 commit into from
Closed

Make resolveDependencies=true the default for phpunit.xml #3540

wants to merge 1 commit into from

Conversation

epdenouden
Copy link
Contributor

@epdenouden epdenouden commented Feb 22, 2019

Fixes #3539

@epdenouden epdenouden changed the title Fix #3529 make resolveDependencies=true the default for phpunit.xml Make resolveDependencies=true the default for phpunit.xml Feb 22, 2019
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #3540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3540   +/-   ##
=========================================
  Coverage     82.91%   82.91%           
  Complexity     3709     3709           
=========================================
  Files           144      144           
  Lines          9672     9672           
=========================================
  Hits           8020     8020           
  Misses         1652     1652

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb5af4...2b2c10d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #3540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3540   +/-   ##
=========================================
  Coverage     82.91%   82.91%           
  Complexity     3709     3709           
=========================================
  Files           144      144           
  Lines          9672     9672           
=========================================
  Hits           8020     8020           
  Misses         1652     1652

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb5af4...2b2c10d. Read the comment docs.

@sebastianbergmann
Copy link
Owner

This needs to go into 8.0.

@epdenouden epdenouden changed the base branch from master to 8.0 February 22, 2019 11:07
@epdenouden epdenouden changed the base branch from 8.0 to master February 22, 2019 11:08
@epdenouden
Copy link
Contributor Author

I'd better make a new branch, changing the base doesn't just stick the one commit on top unfortunately, brb

@epdenouden epdenouden closed this Feb 22, 2019
@epdenouden epdenouden deleted the issue-3529-resolvedependencies-xsd-default branch February 22, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants