Implement option to disable Testdox progress animation

[epdenouden]

Implements #3513 allowing the user to disable the Testdox progress animation.

Changes

• add --no-interaction command line option
• add noInteraction attribute for XML-configuration files
• update configuration unit tests and CLI option tests

Unfortunately I did not manage to get a screenshot.

[codecov]

Codecov Report

Merging #3528 into master will increase coverage by <.01%.
The diff coverage is 96.92%.

@@             Coverage Diff              @@
##             master    #3528      +/-   ##
============================================
+ Coverage     82.84%   82.85%   +<.01%     
- Complexity     3694     3701       +7     
============================================
  Files           144      144              
  Lines          9637     9654      +17     
============================================
+ Hits           7984     7999      +15     
- Misses         1653     1655       +2

Impacted Files	Coverage Δ	Complexity Δ
src/Util/Configuration.php	96.32% <100%> (+0.02%)	181 <0> (+1)	⬆️
src/TextUI/Command.php	71.37% <100%> (+0.14%)	209 <0> (+1)	⬆️
src/Util/TestDox/TestDoxPrinter.php	78.68% <83.33%> (+0.24%)	58 <1> (+3)	⬆️
src/TextUI/TestRunner.php	68.16% <98.07%> (+0.04%)	295 <0> (+2)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeba3b8...e7fbc22. Read the comment docs.

[sebastianbergmann]

Thanks!

I am not sure I like the --no-progress and noProgress names. They can be misunderstood as "no progress output at all".

[epdenouden]

Agreed, the dot-printer also shows progress without animation. It seems --no-progress is relatively common as a GNU-style --arg

I'll change it to '--no-spinner' as I don't think there'll be any other new animations

[sebastianbergmann]

Sounds reasonable. Thanks!

[epdenouden]

While changing the name I just noticed this that composer has a --no-interaction flag which seems perfect and is already used by another large PHP project. Even better I think :)

[Bilge]

This fundamentally misunderstands what no interaction actually means. In the context of Composer it makes sense because we indicate we are not willing or able to interact with the application via terminal (i.e. with readline) thus the application should make a best guess as to which default action should make the most sense in lieu of any user input. In this context, there is no user interaction in either case: this is just an animation spinner; the user cannot interact with it in any way. This should have just been --no-spinner as originally indicated.