Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StringEndsWith matches too loosely (numeric strings) #3505

Merged
merged 3 commits into from Feb 15, 2019
Merged

Fix StringEndsWith matches too loosely (numeric strings) #3505

merged 3 commits into from Feb 15, 2019

Conversation

guilliamxavier
Copy link
Contributor

Fixes #3461 (for 7.5 since 6.5 support just ended)

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #3505 into 7.5 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                7.5    #3505   +/-   ##
=========================================
  Coverage     83.38%   83.38%           
  Complexity     3623     3623           
=========================================
  Files           143      143           
  Lines          9648     9648           
=========================================
  Hits           8045     8045           
  Misses         1603     1603
Impacted Files Coverage Δ Complexity Δ
src/Framework/Constraint/StringEndsWith.php 100% <100%> (ø) 3 <0> (ø) ⬇️
src/Runner/Version.php 66.66% <0%> (ø) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb7597...4745715. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 819afbf into sebastianbergmann:7.5 Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants