Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexed array subset #3499

Closed
wants to merge 12 commits into from
Closed

Indexed array subset #3499

wants to merge 12 commits into from

Commits on Jan 24, 2019

  1. Test ArraySubset with indexed arrays.

    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    07a2ac1 View commit details
    Browse the repository at this point in the history

  2. Add support for indexed arrays to ArraySubset

    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    5ce072c View commit details
    Browse the repository at this point in the history

  3. Stop iterating when a match is found.

    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    49396dd View commit details
    Browse the repository at this point in the history

  4. Refactor anonymous functions to private methods.

    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    56bcdf9 View commit details
    Browse the repository at this point in the history

  5. Fix CS/WS issues

    @sebastianbergmann @Stadly
    sebastianbergmann authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    36161e9 View commit details
    Browse the repository at this point in the history

  6. Test that ArraySubset can handle subsets with duplicate values.

    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    c6c5cc1 View commit details
    Browse the repository at this point in the history

  7. Add support for matching subsets with duplicate values in ArraySubset.

    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    7714277 View commit details
    Browse the repository at this point in the history

  8. Avoid trying to cast non-scalars to strings during sorting.

    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    bdb7223 View commit details
    Browse the repository at this point in the history

  9. Improve readability of a line that uses multiple logical operators. 

    Since `&&` has a higher precendence than `||` the parentheses are unneeded
but adding them makes is easier to understand.
    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    df1d129 View commit details
    Browse the repository at this point in the history

  10. Test a duplicate value located deep in a multidimensional array.

    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    9f7a99a View commit details
    Browse the repository at this point in the history

  11. Add regression test for issue #3240. 

    This proves that the bug reported in #3240 is also fixed in scope of this PR.
    @pfrenssen @Stadly
    pfrenssen authored and Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    d32a86c View commit details
    Browse the repository at this point in the history

  12. Fix style

    @Stadly
    Stadly committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    cf0ca42 View commit details
    Browse the repository at this point in the history